Simplify TranslateOperator implementation across all drivers#7
Merged
pseudomuto merged 1 commit intomainfrom Oct 15, 2025
Merged
Simplify TranslateOperator implementation across all drivers#7pseudomuto merged 1 commit intomainfrom
pseudomuto merged 1 commit intomainfrom
Conversation
Replace switch statements with slice-based lookups for better maintainability and consistency. Adds supportedOperations slice to each driver following the same pattern as supportedFeatures.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the TranslateOperator method across PostgreSQL, MySQL, and ClickHouse drivers by replacing verbose switch statements with slice-based lookups. The change introduces a supportedOperations slice in each driver, following the same pattern as the existing supportedFeatures slice. Additionally, fixes an inconsistent variable naming issue in the ClickHouse driver (supportsFeatures → supportedFeatures).
- Introduces
supportedOperationsslice in each driver for cleaner operator validation - Simplifies
TranslateOperatorlogic usingslices.Containsinstead of switch cases - Fixes variable naming inconsistency in ClickHouse driver
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| drivers/postgres/postgres.go | Adds supportedOperations slice and refactors TranslateOperator to use slice-based lookup |
| drivers/mysql/mysql.go | Adds supportedOperations slice, refactors TranslateOperator, and extracts ILIKE handling into separate condition |
| drivers/clickhouse/clickhouse.go | Adds supportedOperations slice, refactors TranslateOperator, and fixes supportsFeatures typo to supportedFeatures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace switch statements with slice-based lookups for better maintainability and consistency. Adds supportedOperations slice to each driver following the same pattern as supportedFeatures.